Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API request timer regression #6872

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Fix API request timer regression #6872

merged 3 commits into from
Sep 26, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Sep 26, 2024

This fixes the issue introduced yesterday where API requests are incorrectly paused.

Also, some unit tests were added. 🎉


This change is Reviewable

@dlon dlon requested a review from Serock3 September 26, 2024 09:49
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


mullvad-api/src/availability.rs line 97 at r1 (raw file):

        let should_reset = {
            let mut inner = self.acquire();
            inner.resume_background();

The actual fix

Code quote:

inner.resume_background();

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit 8135aea into main Sep 26, 2024
48 checks passed
@dlon dlon deleted the api-fix-pause branch September 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants