Fix connection method test ios 843 #6875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
force-pushed
the
fix-connection-method-test-ios-843
branch
from
a9de42c
to
1d149f5
Compare
rablador
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
mojganii
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Reviewable status:
buggmagnet
force-pushed
the
fix-connection-method-test-ios-843
branch
from
1d149f5
to
a2c27c2
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that only a single instance of
EncryptedDNSTransportis ever used in either process.Important
This should only be merged after #6874
This change is