Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wintun adapter fix to README.md #6903

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

Serock3
Copy link
Contributor

@Serock3 Serock3 commented Oct 2, 2024


This change is Reviewable

@Serock3 Serock3 requested a review from raksooo October 2, 2024 09:05
@Serock3 Serock3 self-assigned this Oct 2, 2024
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)


CHANGELOG.md line 35 at r1 (raw file):

### Fixed
#### Windows
- Add potential fix for a rare error when creating the Mullvad Wintun-adapter for OpenVPN

It was included in the beta right? I suggest we add it to "Fixed" in the 2024.6-beta1 section.

Copy link
Contributor Author

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @raksooo)


CHANGELOG.md line 35 at r1 (raw file):

Previously, raksooo (Oskar Nyberg) wrote…

It was included in the beta right? I suggest we add it to "Fixed" in the 2024.6-beta1 section.

Good catch, fixed

raksooo
raksooo previously approved these changes Oct 2, 2024
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Serock3 Serock3 merged commit 421b5dc into main Oct 3, 2024
11 checks passed
@Serock3 Serock3 deleted the wintun-adapter-fix-readme branch October 3, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants