Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set insets for primary button #7061

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Correctly set insets for primary button #7061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ios/MullvadVPN/View controllers/Tunnel/DisconnectSplitButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
secondaryButton.heightAnchor.constraint(equalToConstant: secondaryButtonSize.height)
}

primaryButton.configuration?.contentInsets.leading += secondaryButtonSize

Check failure on line 45 in ios/MullvadVPN/View controllers/Tunnel/DisconnectSplitButton.swift

View workflow job for this annotation

GitHub Actions / Unit tests 

cannot convert value of type 'CGSize' to expected argument type 'CGFloat'

Check failure on line 45 in ios/MullvadVPN/View controllers/Tunnel/DisconnectSplitButton.swift

View workflow job for this annotation

GitHub Actions / Screenshot tests 

cannot convert value of type 'CGSize' to expected argument type 'CGFloat'

Check failure on line 45 in ios/MullvadVPN/View controllers/Tunnel/DisconnectSplitButton.swift

View workflow job for this annotation

GitHub Actions / Screenshot tests 

cannot convert value of type 'CGSize' to expected argument type 'CGFloat'

// Ideally, we shouldn't need to manually resize the image ourselves.
// However, since UIButton.Configuration doesn't provide a direct property
// for controlling image scaling (like imageScaling or contentMode in other contexts),
Expand Down
Loading