-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info dialog to Encrypted DNS proxy access method #7087
Conversation
d87793d
to
d0ce635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/info/EncryptedDnsProxyInfoDialog.kt
line 24 at r1 (raw file):
fun EncryptedDnsProxyInfo(navigator: DestinationsNavigator) { InfoDialog( message =
Info dialogs needs some cleanup, but I think you can achieve the same effect by just setting message
and additionalInfo
and then you don't need appendLine
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ApiAccessMethodDetailsScreen.kt
line 263 at r1 (raw file):
is ApiAccessMethod.CustomProxy.Socks5Remote -> null ApiAccessMethod.Direct -> null ApiAccessMethod.EncryptedDns -> onNavigateToEncryptedDnsInfoDialog
Should be able to collapse all the null cases to one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/dialog/info/EncryptedDnsProxyInfoDialog.kt
line 24 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Info dialogs needs some cleanup, but I think you can achieve the same effect by just setting
message
andadditionalInfo
and then you don't needappendLine
Discussed offline.
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ApiAccessMethodDetailsScreen.kt
line 263 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Should be able to collapse all the null cases to one
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
dfe2eda
to
fcd967a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
92ee60f
to
ca9f109
Compare
This change is