Do not fallback to making direct API connections when testing access methods

[MarkusPettersson98]

This PR addresses an issue in the logic for testing access methods whre if an access methods fails to resolve to a set of connection details (e.g. if the relay selector / mullvad encrypted dns cache is empty) the daemon would fall back to making a direct API connection. The current behaviour is straight up misleading.

---

This change is 

[Rawa]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

---

mullvad-daemon/src/api.rs line 183 at r1 (raw file):
nit:

Tru to resolve...

Typo?

[Rawa]

LGTM, probably good if Rust dev takes a look as well 👍

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

[MarkusPettersson98]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

mullvad-daemon/src/api.rs line 183 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

nit:

Tru to resolve...

Typo?

Type!

[MarkusPettersson98]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

mullvad-daemon/src/api.rs line 183 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Type!

Typo* Lol

[hulthe]

Reviewed 1 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98 and @Rawa)

---

mullvad-daemon/src/api.rs line 604 at r1 (raw file):

                AccessMethod::BuiltIn(BuiltInAccessMethod::Bridge) => {
                    let Some(bridge) = relay_selector.get_bridge_forced() else {
                        log::warn!("Received unexpected proxy settings type. Defaulting to direct API connection");

Is "Defaulting to direct API connection" still accurate?

[Rawa]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

[Rawa]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

[MarkusPettersson98]

Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @hulthe and @Rawa)

---

mullvad-daemon/src/api.rs line 604 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Is "Defaulting to direct API connection" still accurate?

Well spotted, this log message is outdated 😊
Fixed!

[hulthe]

Reviewed 8 of 8 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved