Clean up workarounds in macOS preinstall script #7162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
macos-preinstall-cleanup
branch
2 times, most recently
from
2168e3d
to
1d01dde
Compare
raksooo
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Clean up the pre-install script on macOS. The GUI can and should be unconditionally killed before running the install script since we have dropped support for app version `2022.5`.
Clean up a command in the pre-install script for macOS. Do not try to remove an unused exclusion group, which is not needed since we dropped support for app version 2023.4 and earlier.
MarkusPettersson98
force-pushed
the
macos-preinstall-cleanup
branch
from
1d01dde
to
e40b2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some workarounds present in the preinstall script for macOS which supposedly can be removed because we no longer support the app versions that these workarounds target. I only noticed this because of log output when running the end-to-end tests.
This change is