Skip to content

Replace @_silgen_name with _cdecl #8090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

acb-mv
Copy link
Contributor

@acb-mv acb-mv commented Apr 29, 2025

Now demangled symbols exported to non-Swift code will use the C calling convention, rather than still using the Swift one.


This change is Reviewable

@acb-mv acb-mv added the iOS Issues related to iOS label Apr 29, 2025
@acb-mv acb-mv requested a review from rablador April 29, 2025 18:10
@acb-mv acb-mv self-assigned this Apr 29, 2025
Copy link

linear bot commented Apr 29, 2025

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the IOS-1189-_silgen_name-to-_cdecl branch from 7295d83 to 311585d Compare May 9, 2025 09:11
@buggmagnet buggmagnet merged commit 8b8f2df into main May 9, 2025
13 checks passed
@buggmagnet buggmagnet deleted the IOS-1189-_silgen_name-to-_cdecl branch May 9, 2025 09:13
Copy link

github-actions bot commented May 9, 2025

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants