aa #8
Open
aa #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft ate nao ser mais draft |
FelipeSouzaF
requested changes
Feb 2, 2024
| @@ -1,2 +1,4 @@ | |||
|
|
|||
|
|
|||
| import Integrity from './Integrity' | |||
| @@ -1,2 +1,4 @@ | |||
|
|
|||
|
@FelipeSouzaF olha q foda isso aqui, tu comenda o nome da issue no jira entre [ ] e ele pega a url do jira |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # .
What
Explain the changes you’ve made.
It doesn’t need to be fancy and you don’t have to get to technical, yet.
Just explicit prose on your net change will typically suffice.
Why
The “why” is sometimes more important than the “what” of a code change,
but we tend to put it after the “what” since we aren’t evaluating theory,
we’re evaluating tangible code changes.
How
Of course, the PR diff will tell most of the story of the “how”,
but make sure to draw attention to the significant design decisions.
You decided to write a recursive method instead of a loop,
pointing out the merits of this will help the reviewer understand
your reasoning and in turn provide a better review.