Fix CVector optional arguments - #3738 #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tederis
reviewed
Oct 9, 2024
tederis
reviewed
Oct 9, 2024
|
Did you forget to push your changes? |
Indeed, gonna push it in a sec |
|
Why did you marked conversations resolved without corresponding changes in the code? |
What do you mean? I updated the code according to your reviews |
Hmm, that's strange. I thought I saw the files untouched. I'm sorry. |
|
Thanks for addressing all reviews and the fix itself |
1 task
tederis
reviewed
Dec 22, 2024
| @@ -561,7 +561,7 @@ struct CLuaFunctionParserBase | |||
| else if constexpr (std::is_same_v<T, CVector>) | |||
| { | |||
| if (lua_isnumber(L, index)) | |||
| return {PopUnsafe<float>(L, index), PopUnsafe<float>(L, index), PopUnsafe<float>(L, index)}; | |||
| return CVector(PopUnsafe<float>(L, index), PopUnsafe<float>(L, index), PopUnsafe<float>(L, index)); | |||
There was a problem hiding this comment.
The order of evaluation of arguments is unspecified. That leads to #3895.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3738, #3778