Update login.html #147
Closed
Update login.html #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### 1. **HTML Structure and Semantics** - The document has a proper DOCTYPE declaration and includes necessary meta tags. - The `<title>` tag is generic; it should be more descriptive for better SEO and usability. ### 2. **CSS Styles** - Inline styles are used extensively, making the code less maintainable. - The `login-container` is positioned with fixed pixel values, which can hinder responsiveness. ### 3. **Accessibility** - While `<label>` elements are used correctly, the code lacks additional `aria` attributes to enhance accessibility. ### 4. **JavaScript Functionality** - The event listener for the login button does not prevent the default form submission, potentially causing unwanted page refresh. - The successful login alert appears after clearing input fields, which can confuse users. ### 5. **Usability Issues** - There is a typo in the "Don't have an account?" text. - The "Forget Password" link lacks clarity regarding its destination. - The back button's extreme positioning is not flexible for various screen sizes.
✅ Deploy Preview for multiverse-dataverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@akshitbansal2005 Resolve all conflicts. Also mention the issue number which you have solved and attach relevant screenshots. |
@akshitbansal2005 can you do the same so we can see what changes you have made? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. HTML Structure and Semantics
<title>tag is generic; it should be more descriptive for better SEO and usability.2. CSS Styles
login-containeris positioned with fixed pixel values, which can hinder responsiveness.3. Accessibility
<label>elements are used correctly, the code lacks additionalariaattributes to enhance accessibility.4. JavaScript Functionality
5. Usability Issues
Description
Please include a summary of the changes and the related issue. Also, explain the motivation behind this PR.
Related Issue
Fixes # (issue)
Type of change
Checklist