Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance UI and Add New Functionalities for Interactive Map and Theme … #259

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

smog-root
Copy link
Contributor

Issue: #254

Kindly add all labels and assign me! @multiverseweb

1. Preloader Enhancements:

  • Adds a 3-second preloader display before the main content loads.
  • Hides the preloader after load completion, ensuring a smooth initial load experience.

2. Navbar Scroll Behavior:

  • Implements scroll-based visibility for the navbar, hiding it on scroll down and showing it on scroll up for better visibility of the main content.

3. Dynamic Map Markers:

  • Fetches and displays markers for multiple cities on the map using OpenStreetMap API.
  • Adds error handling for API requests and displays markers only when coordinates are available.

4. Dark and Light Mode with System Default Support:

  • Adds theme toggling with options for light, dark, and system-default themes.
  • Saves the theme preference to localStorage to persist settings across sessions.
  • Includes smooth indicator animations for active theme display.

5. Form Validation and Local Storage Support:

  • Implements validation for the feedback form to ensure all fields are filled and the email format is correct.
  • Saves form data to localStorage on successful validation.

6. Section Animation on Scroll:

  • Adds animation effects to each section on scroll for a more engaging user experience.

7. Miscellaneous Updates:

  • Adds copyright display with the current year.
  • Refactors event listeners and utility functions for better readability and modularity.

Testing:

  • Manually tested all features across different themes and browser windows.
  • Verified map markers load correctly for predefined cities.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 8e3d289
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/67257881f83aae00085d8d5e
😎 Deploy Preview https://deploy-preview-259--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1 jency1 requested a review from multiverseweb October 29, 2024 15:13
@smog-root
Copy link
Contributor Author

@multiverseweb merge it!!

@smog-root
Copy link
Contributor Author

I have solved conflict!! merge it! @multiverseweb

@multiverseweb multiverseweb merged commit a4b55ce into multiverseweb:main Nov 2, 2024
5 checks passed
Copy link
Contributor

github-actions bot commented Nov 2, 2024

🎉🎉 Thank you for your contribution! Your PR #259 has been merged! 🎉🎉

@multiverseweb
Copy link
Owner

@smog-root there are some bugs this PR has introduced in the website, so I'm reverting it. Kindly fix the bugs and create a new PR for the same. Here are the bugs:

  • Auto scroll of examples not working
    image

  • Angle of airplane in the map not changing
    image

And many more.....
Look for the functions you have removed from script.js file.
Examples of such removed functions are autoScroll, updateAngle, etc. you can find them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants