Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "remember me" to the signup and signin page connecting it to the local storage database for user authentication. #280

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

shriyadindi
Copy link
Contributor

@shriyadindi shriyadindi commented Nov 4, 2024

Description

Added "remember me" to the signup and signin page connecting it to the local storage database for user authentication.

Related Issue

Fixes #278

Sign.Up.-.Brave.2024-11-04.20-41-33.mp4

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit da199a6
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/67291397058a0d0008e9ab57
😎 Deploy Preview https://deploy-preview-280--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse team will review it as soon as possible. We appreciate your support in making this project better

@jency1
Copy link
Contributor

jency1 commented Nov 4, 2024

@shriyadindi LGTM! But there are some issues which need to be fixed to get the PR merged.

Screenshot 2024-11-04 234112

In sign up page, the box is moved to right, so do check it and make it as it was before.

Also, "Don't have an account" is not visible in dark background with dark text. So change that also if you can.

@shriyadindi
Copy link
Contributor Author

Changed the alignment of the signup form and made the dont have account? visible.
Screenshot 2024-11-05 000231

@jency1 jency1 merged commit 17625e9 into multiverseweb:main Nov 4, 2024
5 checks passed
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉🎉 Thank you for your contribution! Your PR #280 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants