Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions count not updating #303 #314

Closed
wants to merge 3 commits into from

Conversation

Rohan20-10
Copy link
Contributor

Description

Related Issue

Fixes # (#303)

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@multiverseweb I have updated the total contributions count in the given code. Please review this pr and let me know if any changes are required. Thanks.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 5009230
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672d86b6bbbc480008ceadaf
😎 Deploy Preview https://deploy-preview-314--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amin-xiv
Copy link
Contributor

amin-xiv commented Nov 6, 2024

For some reason it is not opening for me, the buffer just keeps spinning.

@Rohan20-10
Copy link
Contributor Author

For some reason it is not opening for me, the buffer just keeps spinning.

@amin-xiv yeah even I'm facing the same issue but when I executed, it was loading properly. Thanks for pointing it out.

@jency1
Copy link
Contributor

jency1 commented Nov 6, 2024

For some reason it is not opening for me, the buffer just keeps spinning.

@amin-xiv yeah even I'm facing the same issue but when I executed, it was loading properly. Thanks for pointing it out.

Still there is an issue of buffering, the page is only loading. So fix it, to get the PR merged.

@multiverseweb
Copy link
Owner

@Rohan20-10 @amin-xiv what shall we do? I'm not merging the PR for now as the loader keeps spinning. Another contributor is working on the same issue in my other project CodeIt. Let's see what he comes up with.

@Rohan20-10
Copy link
Contributor Author

@multiverseweb @jency1 I have updated my code. Kindly review it once. Thanks.

@multiverseweb
Copy link
Owner

Hi @Rohan20-10, I don't know why the contributors stats are still not loading. Is it working on your side?

@amin-xiv
Copy link
Contributor

amin-xiv commented Nov 8, 2024

@multiverseweb I have already fixed it last time, but I was told it was not going to be merged because another contributor was working on it, it woks on my local machine, and in the Netlify deploy preview, so can I submit it for PR again? Thank you.

@multiverseweb
Copy link
Owner

Sure @amin-xiv, create a new PR

@amin-xiv
Copy link
Contributor

amin-xiv commented Nov 8, 2024

@multiverseweb #322

@jency1 jency1 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants