Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented infinite scrolling on example images in index.html #383

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NehaaAcharya
Copy link

Description

Summary of Changes:
In this pull request, I implemented infinite scrolling for the example images in the index.html file. The scrolling of the images is continuous, and the user can stop the scrolling by hovering over the individual image rows. Additionally, the hover effect on one row will not affect the other row's scrolling behavior, allowing both rows to scroll independently.

Motivation:
The motivation behind this change is to enhance the user experience by making the examples section dynamic, providing a smoother visual flow, and allowing users to interact with the image carousel seamlessly. It allows both rows to scroll independently.

Related Issue

Fixes # 375

Type of change

  • [ x] Bug fix
  • [ x] New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 0158c13
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/678a548687687c00084606f3
😎 Deploy Preview https://deploy-preview-383--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse will review it as soon as possible. We appreciate your support in making this project better.

Copy link
Owner

@multiverseweb multiverseweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NehaaAcharya , I think you missed some step while pushing changes, only a blank line has been added to index.html in this PR.
image

Let me know if you need any help.

@NehaaAcharya
Copy link
Author

Hi. Thank you for your response. I will recheck and get back to you.

@NehaaAcharya
Copy link
Author

Hi @NehaaAcharya , I think you missed some step while pushing changes, only a blank line has been added to index.html in this PR. image

Let me know if you need any help.

Hi @multiverseweb . I've updated styles.css to include infinite scrolling and hover-pause functionality. Please review the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants