Scenarios for PR 6114 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return keys | ||
|
|
||
|
|
||
| def get_keys_from_validator_statistics(needed_state: str) -> list[str]: |
There was a problem hiding this comment.
Maybe can also be moved in that package called get_infos? Also, perhaps rename that package to network_provider or something similar?
There was a problem hiding this comment.
It is already in get_infos folder. We had before a get_info.py, but I divided it into multiple files based on from where it will take the information : staking, delegation, transactions...etc. I renamed it network_provider
mariusmihaic
requested changes
Apr 25, 2024
mariusmihaic
requested changes
Apr 26, 2024
| def test_PR_6114(): | ||
|
|
||
| # === PRE-CONDITIONS ============================================================== | ||
| AMOUNT_TO_MINT = "10000" + "000000000000000000" |
There was a problem hiding this comment.
It will still be a variable, but having a func, like:
AMOUNT_TO_MINT = getEGLDAmount("10000")
which adds the remaining necessary num of decimals. It should also take care of values < 1 egld
mariusmihaic
requested changes
Apr 26, 2024
mariusmihaic
approved these changes
Apr 26, 2024
andreibancioiu
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenarios for PR 6114
mx-chain-go branch : MX-15360-waiting-list-distribution-leaving-nodes