Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapshotless observing squad in the integrators section #749

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

iulianpascalau
Copy link
Contributor

@iulianpascalau iulianpascalau commented Nov 17, 2023

Description of the pull request (what is new / what has changed)

  • added snapshotless observing squad in the integrators section

Did you test the changes locally ?

  • yes
  • no

Which category (categories) does this pull request belong to?

  • document new feature
  • update documentation that is not relevant anymore
  • add examples or more information about a component
  • fix grammar issues
  • other

@iulianpascalau iulianpascalau self-assigned this Nov 17, 2023
@iulianpascalau iulianpascalau changed the title Added snapshotless observing squad for in the integrators section Added snapshotless observing squad in the integrators section Nov 17, 2023
andreibancioiu
andreibancioiu previously approved these changes Nov 17, 2023
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
Whenever a node is executing the trie snapshotting process, the accounts data fetching & vm-query operations are greatly affected.
This is caused by the fact that the snapshotting operation consumes a large number of CPU cycles along with disk iops.
The nodes started with the flag `--operation-mode snapshotless-observer` will not create trie snapshots on every epoch and will
also prune the trie storage in order to save space.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unnecessary newline above (markdown renderer will ignore it, anyway).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed cessary new-lines

docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
Comment on lines 34 to 37
If you already have an observing squad, and you want to transform it into a snapshotless observing squad, the
easiest way is to manually edit the service file `/etc/systemd/system/elrond-node-x.service` (with `sudo`) and
append the `-operation-mode snapshotless-observer` flag at the end of the `ExecStart=` line.
In the end, the file should look like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, perhaps the editor splits the lines? When writing markdown, I usually only use newlines when changing paragraphs (just an opinion).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed cessary new-lines


[Service]
User=jls
WorkingDirectory=/home/ubuntu/elrond-nodes/node-0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, at some point, the installation scripts should create a symlink (mvx-nodes)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix that with @valentin-lup in the future

docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
ovidiuolteanu
ovidiuolteanu previously approved these changes Nov 17, 2023
docs/integrators/snapshotless-observing-squad.md Outdated Show resolved Hide resolved
@@ -381,6 +381,7 @@ const sidebars = {
items: [
"integrators/observing-squad",
"integrators/deep-history-squad",
"integrators/snapshotless-observing-squad",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the snapshotless-observing-squad page above the deep-history-squad.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. More use-cases, more integrators that require snapshotless squads - as opposed to deep-history squads (more exotic, less used).

andreibancioiu
andreibancioiu previously approved these changes Nov 17, 2023
```
NODE_EXTRA_FLAGS="-log-save -operation-mode snapshotless-observer"
```

After that, wou can resume following the normal observer squad installation steps.
After that, you can resume the normal Observer Squad installation steps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ObservING Squad?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

raduchis
raduchis previously approved these changes Nov 17, 2023
@iulianpascalau iulianpascalau merged commit 18ce22d into development Nov 29, 2023
1 check passed
@iulianpascalau iulianpascalau deleted the snapshotless-observers-for-integrators branch November 29, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants