Tm/upgrade-ledger-2fa #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Sep 25, 2024
|
|
||
| // set sender | ||
| const ledgerSenderBech32 = await this.hwProvider.getAddress(); | ||
| const ledgerSender = new Address(senderBech32); |
There was a problem hiding this comment.
Address.newFromBech32();
https://github.com/multiversx/mx-sdk-js-core/blob/main/src/address.ts#L95
razvantomegea
previously approved these changes
Sep 25, 2024
arhtudormorar
dismissed stale reviews from razvantomegea and andreibancioiu
via
428e496
andreigiura
approved these changes
Sep 25, 2024
razvantomegea
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request
Changed ledger 2FA signing method from using WebWallet provider to CrossWindow provider
Did you test the changes locally ?
Which category (categories) does this pull request belong to?