Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ MEX-662 ] Changed input and output token type to Esdt and fix action on TokenTradingActivity #1556

Merged

Conversation

EmanuelMiron
Copy link
Contributor

@EmanuelMiron EmanuelMiron commented Feb 5, 2025

Reasoning

  • There was a need of multiple Esdt Token attributes on frontend, and we were sending only the token identifier
  • Action on TokenTradingActivity was not working properly, ( the quote / base computation was implemented only for pairTradingActivity )

Proposed Changes

  • Change the model and the compute functions to return EsdtType for inputToken and OutputToken
  • Implement quote / base computation for token Trading Activity

How to test

tradingActivity(series: "erd1qqqqqqqqqqqqqpgq5jnjpsukhl295ry3wjrd3gtff0amrgux2jpsz3reum") {
    hash,
    timestamp,
    action,
    inputToken {
      identifier,
      decimals,
      balance
    },
    outputToken {
      identifier,
      decimals,
      balance
    }
  }

@EmanuelMiron EmanuelMiron changed the title [ MEX-662 ] Changed input and output token type to Esdt and fix action ok TokenTradingActivity [ MEX-662 ] Changed input and output token type to Esdt and fix action on TokenTradingActivity Feb 5, 2025
@claudiulataretu claudiulataretu merged commit 9c0c44e into development Feb 10, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants