Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mex-666] : Split Fiat and Crypto in Redis and use USDC as USD equivalent #1564

Merged
merged 7 commits into from
Feb 21, 2025

Conversation

EmanuelMiron
Copy link
Contributor

Reasoning

  • USD values in the backend service are reffered to USDC value rather than the USD value
  • Crypro Rates are more subjective to cahnge rather than the Fiat rates and they were updated on the same interval

Proposed Changes

  • use USDC to calculate crypto rates
  • Split FIAT and Crypto rates in Redis

How to test

currencyRates (symbols: ["EGLD", "WBTC", "WETH", "EUR"]) {
      symbol
      rate
      category
      name
    }

mad2sm0key
mad2sm0key previously approved these changes Feb 17, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.81%. Comparing base (87683b0) to head (6056068).
Report is 41 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1564      +/-   ##
===============================================
- Coverage        52.90%   52.81%   -0.09%     
===============================================
  Files              269      270       +1     
  Lines            10656    10693      +37     
  Branches           825      827       +2     
===============================================
+ Hits              5638     5648      +10     
- Misses            4278     4303      +25     
- Partials           740      742       +2     
Flag Coverage Δ
unittests 52.81% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
Signed-off-by: Claudiu Lataretu <claudiu.lataretu@gmail.com>
@claudiulataretu claudiulataretu merged commit 79fc32f into development Feb 21, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants