Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MES-702] Return promises instead of await #1574

Open
wants to merge 16 commits into
base: development
Choose a base branch
from

Conversation

mad2sm0key
Copy link
Contributor

@mad2sm0key mad2sm0key commented Feb 27, 2025

Reasoning

  • Every await creates a new microtask in the event loop

Proposed Changes

  • Return promises directly where possible

How to test

  • N/A

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 26.63317% with 292 lines in your changes missing coverage. Please review.

Project coverage is 52.80%. Comparing base (3821301) to head (60bd117).
Report is 16 commits behind head on development.

Files with missing lines Patch % Lines
src/modules/pair/services/pair.compute.service.ts 0.00% 35 Missing ⚠️
...rc/modules/staking/services/staking.abi.service.ts 0.00% 31 Missing ⚠️
...ules/farm/base-module/services/farm.abi.service.ts 0.00% 20 Missing ⚠️
src/modules/pair/services/pair.abi.service.ts 0.00% 19 Missing ⚠️
...c/modules/tokens/services/token.compute.service.ts 6.66% 14 Missing ⚠️
...odules/staking/services/staking.compute.service.ts 7.14% 13 Missing ⚠️
...es/analytics/services/analytics.compute.service.ts 0.00% 10 Missing ⚠️
src/modules/router/services/router.abi.service.ts 0.00% 10 Missing ⚠️
src/modules/user/services/user.metaEsdt.service.ts 9.09% 10 Missing ⚠️
src/modules/energy/services/energy.abi.service.ts 0.00% 9 Missing ⚠️
... and 35 more
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1574      +/-   ##
===============================================
- Coverage        52.83%   52.80%   -0.04%     
===============================================
  Files              271      271              
  Lines            10756    10765       +9     
  Branches           852      858       +6     
===============================================
+ Hits              5683     5684       +1     
- Misses            4309     4311       +2     
- Partials           764      770       +6     
Flag Coverage Δ
unittests 52.80% <26.63%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mad2sm0key mad2sm0key marked this pull request as ready for review February 27, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants