Update TransactionOnNetwork to specs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
danielailie
approved these changes
Nov 13, 2024
andreibancioiu
approved these changes
Nov 13, 2024
| if len(pubkey) != PUBKEY_LENGTH: | ||
| raise BadPubkeyLengthError(len(pubkey), PUBKEY_LENGTH) | ||
|
|
||
| self.pubkey = bytes(pubkey) | ||
| self.hrp = hrp | ||
|
|
||
| @classmethod |
Comment on lines
+222
to
+224
| sc_result = get_empty_smart_contract_result() | ||
| sc_result.data = bytes.fromhex("4036663662") | ||
| sc_result.logs = logs |
There was a problem hiding this comment.
This is somehow more verbose than before. 💭
Comment on lines
+51
to
+58
| sender = Address.new_from_bech32(response.get("sender", "")) | ||
| receiver = Address.new_from_bech32(response.get("receiver", "")) | ||
| hash = bytes.fromhex(tx_hash) | ||
| nonce = response.get("nonce", -1) | ||
| round = response.get("round", -1) | ||
| epoch = response.get("epoch", -1) | ||
| timestamp = response.get("timestamp", 0) | ||
| block_hash = bytes.fromhex(response.get("blockHash", "")) |
There was a problem hiding this comment.
Verbose, but explicit, good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
TransactionOnNetworkclass to match the specs.