Implemented account transactions factory #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssd04
reviewed
Mar 4, 2024
multiversx_sdk/core/transactions_factories/account_transactions_factory.py
Show resolved
Hide resolved
| sender=sender, | ||
| receiver=contract, | ||
| data_parts=data_parts, | ||
| gas_limit=6_000_000, |
There was a problem hiding this comment.
have constants for gas_limit here? and also on next function
There was a problem hiding this comment.
Added two constants.
multiversx_sdk/core/transactions_factories/account_transactions_factory.py
Show resolved
Hide resolved
andreibancioiu
approved these changes
Mar 6, 2024
ssd04
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the
AccountTransactionsFactorybased on the specs.Also added two new methods for the
SmartContractTransactionsFactoryaccording to the specs.