Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jupyter notebook with examples #9

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Added jupyter notebook with examples #9

merged 4 commits into from
Feb 8, 2024

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Feb 7, 2024

Took the examples from here, changed them a bit to work with the new package and updated the relayed transactions examples.

The notebook can be easily seen here.

@popenta popenta self-assigned this Feb 7, 2024
pyproject.toml Outdated
exclude = [
".github",
"./examples",
".vscode"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also multiversx_sdk/testutils/testdata?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@@ -0,0 +1,5 @@
-----BEGIN PRIVATE KEY for erd1u65ey3mk7n9z6awg7wcww578cq9q8u99lj874dh40rxakszyw6rq4mc4kv-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can gitignore examples/output.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git ignored the output of the examples

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm curious about the relation with docs cookbook, is it embedded from here or from examples repo? i'm thinking if a tool like jupytext might be worth considering, in order to save it as py file instead of ipynb

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples repo won't be used anymore since we moved the examples here, but the docs cookbook was generated from the examples repo. From now on, it will be generated from here. I don't know if we need it as a python file because it's very easy to run cells in a jupyter notebook, but we might consider it in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea, this one with jupytext, let's keep it in mind 💡

andreibancioiu
andreibancioiu previously approved these changes Feb 8, 2024
andreibancioiu
andreibancioiu previously approved these changes Feb 8, 2024
@popenta popenta merged commit b4c00f0 into main Feb 8, 2024
3 checks passed
@popenta popenta deleted the merge-examples branch February 8, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants