Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added unset special roles in factory. #93

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Added unset special roles in factory. #93

merged 4 commits into from
Sep 5, 2024

Conversation

cristure
Copy link
Contributor

@cristure cristure commented Sep 4, 2024

No description provided.

andreibancioiu
andreibancioiu reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the network providers tests, maybe use some devnet transactions as samples, since the testnet ones are now missing (and the tests are failing)?

multiversx_sdk/core/transactions_factories/token_management_transactions_factory.py Outdated
sender: IAddress,
user: IAddress,
token_identifier: str,
remove_role_nft_create: bool = False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end, as discussed with Alex, this parameter can be dropped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  multiversx_sdk/core/transactions_factories
  token_management_transactions_factory.py
Project Total  

This report was generated by python-coverage-comment-action

@cristure cristure merged commit 61321f4 into main Sep 5, 2024
7 checks passed
@cristure cristure deleted the add_unset_special_role_1 branch September 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popenta popenta popenta approved these changes

@andreibancioiu andreibancioiu andreibancioiu approved these changes

Assignees

@cristure cristure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristure @andreibancioiu @popenta