-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix commit 61f1815 #14
Conversation
@metzm since the tests are not run automatically, the question is they still work with the changes? |
The tests already failed for PR #11, I had to re-enable the hack for Hessen. Regarding Hessen, a better solution would be to assign the correct CRS to the input data as done for Thüringen, see new code comment. Regarding Thüringen, any reason why a CRS is assigned to the input data only if an aoi_map is given? |
@metzm Can we simply change https://github.com/mundialis/v.alkis.buildings.import/blob/fix_import_flags/v.alkis.buildings.import.py#L329C35-L329C40 and us the EPSG code of the current location? |
This could work since in the Thüringen case But then, why not just replacing |
I have changed the special treatment of Hessen and Thüringen to the best of my knowledge. All tests are passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :)
In commit 61f1815 for PR #11, the import flags in
import_single_alkis_source()
have been deactivated, but two instances have not been commented out. As a result,flags
becomes automatically initialized to invalidd,r
when reaching L384 and L392. This PR fixes this.