Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DOM API #171

Merged
merged 6 commits into from
Mar 30, 2024
Merged

Refactor DOM API #171

merged 6 commits into from
Mar 30, 2024

Conversation

mundschenk-at
Copy link
Owner

@mundschenk-at mundschenk-at commented Mar 30, 2024 •
edited
Loading

  • Removes unused or obsolete methods from class PHP_Typography\DOM:
    • ::get_block_parent_name
    • ::get_previous_textnode
    • ::get_next_textnode
    • ::get_last_textnode
  • Adds type declarations to all methods.
  • Renames ::get_prev_chr to ::get_previous_character.
  • Renames ::get_next_chr to ::get_next_character.
  • Cleans up private methods.

@mundschenk-at mundschenk-at added this to the 7.0.0 milestone Mar 30, 2024
@mundschenk-at mundschenk-at self-assigned this Mar 30, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mundschenk-at mundschenk-at merged commit 0b48106 into main Mar 30, 2024
10 checks passed
@mundschenk-at mundschenk-at deleted the refactor-dom branch March 30, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mundschenk-at mundschenk-at

Labels
refactoring
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mundschenk-at