Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Hyphenator and its dependancies #172

Merged
merged 3 commits into from
May 16, 2024
Merged

Refactor Hyphenator and its dependancies #172

merged 3 commits into from
May 16, 2024

Conversation

mundschenk-at
Copy link
Owner

@mundschenk-at mundschenk-at commented Mar 31, 2024 •
edited
Loading

  • Removes unnecessary default values from methods.
  • Adds type declarations.
  • Extracts new method ::read_patterns_from_file method.

@mundschenk-at mundschenk-at added this to the 7.0.0 milestone Mar 31, 2024
@mundschenk-at mundschenk-at self-assigned this Mar 31, 2024
@mundschenk-at mundschenk-at force-pushed the refactor-hyphenator branch 3 times, most recently from 085b23f to a830c90 Compare May 16, 2024 19:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mundschenk-at mundschenk-at merged commit d2a6016 into main May 16, 2024
10 checks passed
@mundschenk-at mundschenk-at deleted the refactor-hyphenator branch May 16, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mundschenk-at mundschenk-at

Labels
refactoring
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mundschenk-at