Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for the Settings class #176

Merged
merged 4 commits into from
May 18, 2024
Merged

Minor improvements for the Settings class #176

merged 4 commits into from
May 18, 2024

Conversation

mundschenk-at
Copy link
Owner

@mundschenk-at mundschenk-at commented May 18, 2024 •
edited
Loading

  • Uses sha256 instead of md5 for generating hashes.
  • Adds type declarations.
  • Removes legacy string parsing (using Strings::maybe_split_parameters or direct regular expression) for settings expecting an array. Fixes Simplify settings methods #100.
  • Removes the now unused static method Strings::maybe_split_parameters.

@mundschenk-at mundschenk-at added this to the 7.0.0 milestone May 18, 2024
@mundschenk-at mundschenk-at self-assigned this May 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mundschenk-at mundschenk-at merged commit 479fac9 into main May 18, 2024
11 checks passed
@mundschenk-at mundschenk-at deleted the slight-improvements-for-settings branch May 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mundschenk-at mundschenk-at

Labels
refactoring
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Simplify settings methods
1 participant
@mundschenk-at