Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GHA workflow #180

Merged
merged 1 commit into from
May 20, 2024
Merged

Improve GHA workflow #180

merged 1 commit into from
May 20, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 20, 2024

  • Explicitly uses composer run-script.
  • Uses composer update instead of composer install as there is no composer.lock file in the repository.
  • Cleans up the Spellchecking workflow.

@mundschenk-at mundschenk-at self-assigned this May 20, 2024
@mundschenk-at
Copy link
Owner

What are the actual benefits? I can see how using composer run-script is more explicit, but why would update be preferred over install?

(The naming of the steps of the typos workflow is C&P from their documentation BTW, seems more like a matter of taste to me.)

@szepeviktor
Copy link
Contributor Author

but why would update be preferred over install?

install + no lock file produces

No composer.lock file present. Updating dependencies to latest instead of installing from lock file.

e.g. https://github.com/mundschenk-at/php-typography/actions/runs/9156609071/job/25171300906#step:7:9

@mundschenk-at mundschenk-at added this to the 7.0.0 milestone May 20, 2024
@mundschenk-at
Copy link
Owner

Could you please prefix the commit comment with Meta:? (I am not sure if I can edit the comment when using Squash and merge as I've never used that option.)

@szepeviktor
Copy link
Contributor Author

Could you please prefix the commit comment with Meta:

Done 🍏

@szepeviktor
Copy link
Contributor Author

Could you please prefix the commit comment

Please add a PR template to notify contributors about your standards.

@mundschenk-at
Copy link
Owner

Please add a PR template to notify contributors about your standards.

Yeah, I should do that. Yours are the first PRs not authored by myself though.

@mundschenk-at mundschenk-at merged commit c7b5649 into mundschenk-at:main May 20, 2024
10 checks passed
@szepeviktor
Copy link
Contributor Author

Glad to contribute to your projects.

Yours are the first PRs not authored by myself though.

😲

@szepeviktor szepeviktor deleted the patch-1 branch May 20, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants