Final Project Submission #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unabashed victory for me.
Ready to present
…es so d3 isn't flagged.
<footer> and <head> don't apply to this, <nav> and <main> maybe do. The only elements that Tabbing recognizes is the buttons.
- Changed color scheme to increase contrast between low, moderate, and middle income unit designations. This necessitated some other adjustments in the other colors as well. I shifted the middle-income units to a yellow-ish green since they -Increased contrast of Approved Plans//Current Progress buttons from background -For Approved Plans, changed outlines of the buildings or structures that have not been completed yetRemoved hammers, as white outline is enough distinction that a building is not complete and they will eventually conflict with the B# labels. Could add them back into the tooltip or if necessary. -Added unit counts to the bottom bar through mouseover effects. I attempted to solve this through direct labels too, but the result was too cluttered and was difficult to solve elegantly for the moderate income sliver. -Removed all underscores from labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Mjumbe, unfortunately ESLint does not cooperate with d3 and labels each instance where I type "d3.blahblahblah" as an undeclared item, so I marked files or lines for eslint to not address them (after it linted everything else). I've done what I think is compatible with the current tests. Thanks!