Skip to content

switch to non native save dialog for Linux #29907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

switch to non native save dialog for Linux #29907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/framework/global/internal/interactive.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@

#endif

#ifndef Q_OS_LINUX
#ifdef Q_OS_LINUX
static QString filterToString(const std::vector<std::string>& filter)
{
QStringList result;
Expand All @@ -295,8 +295,8 @@
const std::vector<std::string>& filter)
{
#ifndef Q_OS_LINUX
return async::make_promise<io::path_t>([title, dir, filter](auto resolve, auto reject) {

Check failure on line 298 in src/framework/global/internal/interactive.cpp

View workflow job for this annotation

GitHub Actions / windows_x64 

'muse::async::make_promise': no overloaded function could convert all the argument types
QFileDialog* dlg = new QFileDialog(nullptr, QString::fromStdString(title), dir.toQString(), filterToString(filter));

Check failure on line 299 in src/framework/global/internal/interactive.cpp

View workflow job for this annotation

GitHub Actions / windows_x64 

'filterToString': identifier not found

dlg->setFileMode(QFileDialog::ExistingFile);

Expand Down Expand Up @@ -341,7 +341,7 @@
io::path_t Interactive::selectOpeningFileSync(const std::string& title, const io::path_t& dir, const std::vector<std::string>& filter)
{
#ifndef Q_OS_LINUX
QString result = QFileDialog::getOpenFileName(nullptr, QString::fromStdString(title), dir.toQString(), filterToString(filter));

Check failure on line 344 in src/framework/global/internal/interactive.cpp

View workflow job for this annotation

GitHub Actions / windows_x64 

'filterToString': identifier not found
return result;
#else

Expand All @@ -359,15 +359,16 @@
io::path_t Interactive::selectSavingFileSync(const std::string& title, const io::path_t& dir, const std::vector<std::string>& filter,
bool confirmOverwrite)
{
#ifndef Q_OS_LINUX
#ifdef Q_OS_LINUX
QFileDialog::Options options;
options.setFlag(QFileDialog::DontConfirmOverwrite, !confirmOverwrite);
options.setFlag(QFileDialog::DontUseNativeDialog, true);
QString result = QFileDialog::getSaveFileName(nullptr, QString::fromStdString(title), dir.toQString(), filterToString(
filter), nullptr, options);
return result;
#else

UriQuery q = makeSelectFileQuery(FileDialogMode::SaveFile, title, dir, filter, confirmOverwrite);

Check failure on line 371 in src/framework/global/internal/interactive.cpp

View workflow job for this annotation

GitHub Actions / windows_x64 

'makeSelectFileQuery': identifier not found

Check failure on line 371 in src/framework/global/internal/interactive.cpp

View workflow job for this annotation

GitHub Actions / windows_x64 

'SaveFile': undeclared identifier

Check failure on line 371 in src/framework/global/internal/interactive.cpp

View workflow job for this annotation

GitHub Actions / windows_x64 

'FileDialogMode': is not a class or namespace name

RetVal<Val> rv = provider()->openSync(q);
if (!rv.ret) {
Expand Down
Loading