Add stacked capo chord display with configurable styling #31219
+778
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaskocode
force-pushed
the
24413-capoed-chord-styling
branch
from
5b7ef16 to
28dddd6
Compare
Resolves: musescore#18691 Add data model foundation for stacked capo chord display: - Add CapoChordDisplayMode enum (INLINE/STACKED) in types.h - Add 9 new style properties (Sid) in styledef.h: - capoChordDisplayMode, capoChordParenthesized - capoChordTextStyle, capoChordStackedSpacing - capoLabelVisible, capoLabelFormat, capoLabelTextStyle - Set default values in styledef.cpp for backward compatibility
Implements the rendering logic for stacked capo chord display: - Add buildFontFromTextStyle() helper for capo chord font styling - Add layoutCapoLabel() to render "Capo N:" label left of first chord - Implement STACKED mode in renderSingleHarmony(): - Position capo chord above base chord with configurable spacing - Center capo chord horizontally over base chord - Apply separate text style (HARMONY_B default) to capo chord - Handle parentheses with proper centering compensation - Add calculateCapoTpc() for transposition calculations - Call layoutCapoLabel() from systemlayout.cpp after harmony layout
Add user interface for configuring capo chord display in Format > Style > Chord Symbols > Capo section: - Add Q_PROPERTY declarations and accessors in chordsymbolspagemodel - Add dropdown option providers for display mode and text style - Add QML controls in ChordSymbolsPage.qml: - Display mode dropdown (Inline/Stacked) - Capo chord text style selector - Parenthesized checkbox (stacked mode only) - Stacked spacing control - Label visibility checkbox - Label format text field - Label text style selector - Controls enable/disable based on current mode selection
Add Google Test cases for capo chord styling feature: - capoDisplayModeRoundTrip: Verify capoChordDisplayMode and capoChordParenthesized persist through save/load cycle - capoDisplayModeDefaults: Verify backward compatibility defaults (INLINE mode, parentheses enabled) - capoEnhancedStylesRoundTrip: Verify all enhanced style properties (text style, spacing, label settings) persist correctly - capoEnhancedStylesDefaults: Verify enhanced property defaults (HARMONY_B style, 0.8sp spacing, label visible)
blaskocode
force-pushed
the
24413-capoed-chord-styling
branch
from
28dddd6 to
ae533b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18691
Summary
Implements a new stacked display mode for capo chord symbols with comprehensive styling options, allowing guitarists to see capo chords displayed above base chords in a professional lead-sheet format.
Before (Inline only)
After (Stacked option)
Changes
CapoChordDisplayModeenum (INLINE/STACKED)capoChordDisplayMode,capoChordParenthesizedcapoChordTextStyle,capoChordStackedSpacingcapoLabelVisible,capoLabelFormat,capoLabelTextStyleTest plan
ctest --test-dir build -R chordsymbol