Skip to content

Fix #30277: Add API access to the ‘ornament’ property of Trills #31272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2025
+17 −1
Merged

Fix #30277: Add API access to the ‘ornament’ property of Trills #31272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61040c3
Initial commit
mnorrisvuw Nov 28, 2025
e059242
Revised based on cbjeukendrup suggestion
mnorrisvuw Nov 30, 2025
a43dc31
Cleanup redundant include/fwddecl
cbjeukendrup Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/engraving/api/v1/elements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "engraving/dom/spacer.h"
#include "engraving/dom/system.h"
#include "engraving/dom/tremolotwochord.h"
#include "engraving/dom/trill.h"

#include "engraving/editing/editnote.h"
#include "engraving/editing/editsystemlocks.h"
Expand Down Expand Up @@ -649,6 +650,18 @@ bool Staff::isVoiceVisible(int voice)
return staff()->isVoiceVisible(voice);
}

//---------------------------------------------------------
// Spanner::ornament
//---------------------------------------------------------

Ornament* Spanner::ornament() const
{
if (spanner()->isTrill()) {
return wrap<Ornament>(toTrill(spanner())->ornament());
}
return nullptr;
}

//---------------------------------------------------------
// wrap
/// \cond PLUGIN_API \private \endcond
Expand Down
5 changes: 4 additions & 1 deletion src/engraving/api/v1/elements.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2301,7 +2301,8 @@ class Spanner : public EngravingItem
Q_PROPERTY(apiv1::EngravingItem * endElement READ endElement)
/// List of spanner segments belonging to this spanner.
Q_PROPERTY(QQmlListProperty<apiv1::SpannerSegment> spannerSegments READ spannerSegments)

/// The ornament object of this spanner
Q_PROPERTY(apiv1::Ornament * ornament READ ornament)
/// \cond MS_INTERNAL

public:
Expand All @@ -2319,6 +2320,8 @@ class Spanner : public EngravingItem
return wrapContainerProperty<SpannerSegment>(this, spanner()->spannerSegments());
}

Ornament* ornament() const;

/// \endcond
};

Expand Down
Loading