Skip to content

Change default value for tablature position, Do not write tab under tied notes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thibibi wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Change default value for tablature position, Do not write tab under tied notes #4

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82e4f7b
Tablature par défaut en position Lower, et pas d'écriture de la tabla…
Thibibi Dec 16, 2018
80efba1
Comments in english
Thibibi Dec 16, 2018
5731918
Version and credits
Thibibi Dec 16, 2018
a672811
Indentation
Thibibi Dec 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions harmonica_tablature.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ import QtQuick.Layouts 1.1
import MuseScore 1.0

MuseScore {
version: "2.0"
description: "Harmonica Tab plugin"
version: "2.1"
description: "Harmonica Tab plugin\nhttps://github.com/lasconic/harmonica_tablature\nContributors: Lasconic, Thierz"
menuPath: "Plugins.Harmonica Tablature"
pluginType: "dialog"

Expand Down Expand Up @@ -100,7 +100,9 @@ MuseScore {
}
}
ComboBox {
currentIndex: 1
currentIndex: 3
// Lower by default, prefered harp players' position
// Lower par défaut, position préférée des harmonicistes
model: ListModel {
id: placetext
property var position
Expand Down Expand Up @@ -239,8 +241,13 @@ MuseScore {
if (typeof tab === "undefined")
text.text = "X";
else {
if (bendChar !== "b")
if (notes[i].tieBack != null) {
// No tab if the note is tied
// Pas de tablature si la note est une note liée
tab = ""
} else if (bendChar !== "b") {
tab = tab.replace(/b/g, bendChar);
}
text.text = tab + text.text;
}
}
Expand Down