add ram dump, fix some typo and add some minor improvements #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutur4
reviewed
Jun 24, 2025
|
|
||
| while True: | ||
| if(g_ft.device_connect()): break | ||
| while not g_ft.device_connect(): |
Owner
There was a problem hiding this comment.
The initial code was more optimized.
mutur4
reviewed
Jun 24, 2025
| #The execution of FDL-1 | ||
| g_ft.cmd_data_exec() | ||
| log.info("FDL version: {}".format(g_ft.read_version())) | ||
|
|
Owner
There was a problem hiding this comment.
FDL-1 is more like a first stage secondary bootloader (SPL) cannnot be used to read/dump memory. It only accepts the following commands in respect to the Unisoc Protocol:
BSL_CMD_START_DATABSL_CMD_MIDST_DATABSL_CMD_END_DATABSL_CMD_EXEC_DATA
mutur4
requested changes
Jun 24, 2025
Owner
mutur4
left a comment
mutur4
left a comment
There was a problem hiding this comment.
Check the above inline comments for changes :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.