Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Udpate github actions to fix deprecation warnings #134

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Udpate github actions to fix deprecation warnings #134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64bea73
Udpate github actions to fix deprecation warnings
acrespo Nov 2, 2023
9e9e9be
Reference actions by commit for reproducibility sakes
acrespo Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/build-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,32 +8,32 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32
uses: docker/setup-buildx-action@v3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather we still point to commit hashes, for reproducibility sakes'. Tags can change, we can add a comment with the version for future happyness though.

with:
buildkitd-flags: --debug

- name: Checkout
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
uses: actions/checkout@v4

- name: Create output dir
run: |
mkdir -p apk

- name: Build
uses: docker/build-push-action@9379083e426e2e84abb80c8c091f5cdeb7d3fd7a
uses: docker/build-push-action@v5
with:
file: android/Dockerfile
context: .
outputs: apk

- name: Upload APK
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
uses: actions/upload-artifact@v3
with:
name: apk
path: apk/apolloui-prod-release-unsigned.apk

- name: Upload mapping
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
uses: actions/upload-artifact@v3
with:
name: mapping
path: apk/mapping.txt
9 changes: 5 additions & 4 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@154c24e1f33dbb5865a021c99f1318cfebf27b32
uses: docker/setup-buildx-action@v3.0.0

with:
buildkitd-flags: --debug

- name: Checkout
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
uses: actions/checkout@v4

# https://github.com/gradle/wrapper-validation-action/releases/tag/v1.0.5
- name: Validate Gradle wrapper
Expand All @@ -21,14 +22,14 @@ jobs:
mkdir -p apk

- name: Build
uses: docker/build-push-action@9379083e426e2e84abb80c8c091f5cdeb7d3fd7a
uses: docker/build-push-action@v5
with:
file: android/Dockerfile
context: .
outputs: apk

- name: Upload APK
uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571
uses: actions/upload-artifact@v3
with:
name: apk
path: apk/apolloui-prod-release-unsigned.apk