Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apollo: Release source code for 51.11 #150

Merged
merged 1 commit into from
May 19, 2024
Merged

Apollo: Release source code for 51.11 #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ follow [https://changelog.md/](https://changelog.md/) guidelines.

## [Unreleased]

## [51.11] - 2024-05-18

### FIXED

- Removed debug log of sensitive data

## [51.10] - 2024-05-17

### ADDED
Expand Down
8 changes: 1 addition & 7 deletions android/apollo/src/main/java/io/muun/apollo/domain/model/IncomingSwap.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ open class IncomingSwap(
val libwalletNetwork = network.toLibwallet()
val libwalletFullfillmentData = data.toLibwalletModel()

debugLog(htlc!!, libwalletFullfillmentData, libwalletUserKey, libwalletMuunKey)
debugLog(htlc!!, libwalletFullfillmentData, libwalletMuunKey)

try {
val result = toLibwalletModel().fulfill(
Expand All @@ -87,7 +87,6 @@ open class IncomingSwap(
private fun debugLog(
htlc: IncomingSwapHtlc,
fullfillmentData: libwallet.IncomingSwapFulfillmentData,
userKey: libwallet.HDPrivateKey,
muunKey: libwallet.HDPublicKey,
) {
Timber.d("---IncomingSwap---")
Expand All @@ -108,11 +107,6 @@ open class IncomingSwap(
Timber.d("HtlcBlock: ${Encodings.bytesToHex(htlcBlock)}")
Timber.d("ConfTarget: ${fullfillmentData.confirmationTarget}")

Timber.d("---UserKey---")
Timber.d("Base58: ${userKey.string()}")
Timber.d("Path: ${userKey.path}")
Timber.d("Network: ${userKey.network.name()}")

Timber.d("---muunKey---")
Timber.d("Base58: ${muunKey.string()}")
Timber.d("Path: ${muunKey.path}")
Expand Down
4 changes: 2 additions & 2 deletions android/apolloui/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ android {
applicationId "io.muun.apollo"
minSdkVersion 19
targetSdkVersion 33
versionCode 1110
versionName "51.10"
versionCode 1111
versionName "51.11"

// Needed to make sure these classes are available in the main DEX file for API 19
// See: https://spin.atomicobject.com/2018/07/16/support-kitkat-multidex/
Expand Down