Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hydration Issue on BackgroundVideo #340

Conversation

ronalduQualabs
Copy link
Contributor

@ronalduQualabs ronalduQualabs commented Jan 29, 2025

This corrects the Issue by

  • Addind Suspense on render of Background Video component
  • Addind suppressHydrationWarning prop in Media tag inside Background Video

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-video-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 4:54pm

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.98%. Comparing base (36b6602) to head (0e53492).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   85.98%   85.98%           
=======================================
  Files          36       36           
  Lines        2982     2982           
  Branches      377      376    -1     
=======================================
  Hits         2564     2564           
  Misses        416      416           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ronalduQualabs ronalduQualabs merged commit 9e6e292 into muxinc:main Jan 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants