Adding Aspect Ratio to Display

[adragnevVW]

Adding parameters for Display geometry object

Issue:
The Display object was not containing the Aspect Ratio of the screen.

[AndriiVoitenko]

Have I missed something? According to specification there is no AspectRatio xml attribute in Geometry type Display.

[adragnevVW]

Hi @AndriiVoitenko,
I know that it is not in the spec, but I think we need to consider adding it, because this one of the main parameters of displays.

[adragnevVW]

Is there any other way how we can export the ratio of the Screens?

[AndriiVoitenko]

You are right, and there was already discussion about ration aspec. Nevertheless I am not sure about type of this value. Yes string can handle everything, but those everything will cause problems by controller and visualizer, maybe enum or at least some predefined value will be more suitable for it. Next question would be is it a mandatory xml attribute or optional one. In your current implementation it is mandatory one (as you do not has HasRatioAspec function) and empty as default value. And if it is, as you say "main parameters of display" then it should have suitable default value, otherwise it would not help you to visualize it.

Long story short: from my point of view, we need clarification on it before implement it in the library.

[adragnevVW]

@AndriiVoitenko I think you are right, we need to discuss it more what we need to add about the displays. Also my opinion is that it need to me mandatory, because of that every screen have specific ratio.