Add Getter accessor for <GDTF DataVersion>#118
Add Getter accessor for <GDTF DataVersion>#118jordan-walters wants to merge 3 commits intomvrdevelopment:masterfrom
Conversation
| //------------------------------------------------ | ||
| // Parameters for the GdtfDataFile | ||
| TXString gdtfFileVersion = XML_GDTF_CurrentVersion; | ||
| TXString gdtfLatestVersion = XML_GDTF_CurrentVersion; |
There was a problem hiding this comment.
What do you mean with gdtfLatestVersion? GDTF file have only one version.
There was a problem hiding this comment.
Well, a GDTF file could be an old one that was made using GDTF version 1.1, so GetGDTFFile would return 1.1
I would also like a function to return the latest GDTF Version that is available in GDTF-Share, i.e. 1.2.
| //---------------------------------------------------------------------------------------------------------------------------------------------------------------- | ||
| // Getter | ||
| const TXString& GetGdtfFileVersion() const { return gdtfFileVersion; } | ||
| const TXString& GetCurrentGdtfVersion() const { return gdtfLatestVersion; } |
There was a problem hiding this comment.
same question here: Why you need 2 APIs GetGdtfFileVersion and GetCurrentGdtfVersion? GDTF file can have only one version.
| private: | ||
| //------------------------------------------------ | ||
| // Parameters for the GdtfDataFile | ||
| TXString gdtfFileVersion = XML_GDTF_CurrentVersion; |
There was a problem hiding this comment.
it looks like all member variable had a prefix "f" in the name. So please adapt you changes.
|
Hi @AndriiVoitenko, |
Yes, that is good to use previous fix you made. If it makes it easier maybe the current latest GDTF Version could be const or #defined. |
|
Hi @jordan-walters , |
Hello Andrii. Yes that makes sense. A new issue to provide function to return the latest/highest version of GDTF file (currently 1.2) |
|
Thank you @jordan-walters! I will close this pull request. Please create a new issue, which we can start discuss. Thank you so much! |
|
New issue created for latest/current GDTF Version. #126 |
3 participants
Needed when importing MVR to ensure all contained GDTFs are using the same (and most up-to-date) GDTF Version