Engine #277
Merged
Engine #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/wireframes/components/CustomDragLayer.tsx # src/wireframes/components/EditorView.tsx # src/wireframes/engine/interface.ts # src/wireframes/engine/svg/canvas/SvgCanvas.tsx # src/wireframes/engine/svg/engine.ts # src/wireframes/engine/svg/item.ts # src/wireframes/engine/svg/layer.ts # src/wireframes/engine/svg/line.ts # src/wireframes/engine/svg/object.ts # src/wireframes/engine/svg/rect-or-ellipse.ts # src/wireframes/engine/svg/renderer.ts # src/wireframes/engine/svg/svg-renderer2.stories.tsx # src/wireframes/engine/svg/text.ts # src/wireframes/engine/svg/utils.ts # src/wireframes/interface/index.ts # src/wireframes/renderer/Editor.tsx # src/wireframes/renderer/NavigateAdorner.tsx # src/wireframes/renderer/SelectionAdorner.tsx # src/wireframes/renderer/TextAdorner.tsx # src/wireframes/renderer/TransformAdorner.tsx # src/wireframes/renderer/interaction-overlays.ts # src/wireframes/shapes/ShapeRenderer.tsx
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
==========================================
- Coverage 75.52% 74.73% -0.79%
==========================================
Files 64 65 +1
Lines 3301 3297 -4
Branches 606 602 -4
==========================================
- Hits 2493 2464 -29
- Misses 691 718 +27
+ Partials 117 115 -2 ☔ View full report in Codecov by Sentry. |
|
This seems to be a rather large change. I'm getting started on some changes to this project. What's the status of the PR? Is it going to land soon? Should I base my work on this? |
|
I have actually forgotten to merge it...done. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.