Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this project, I've really enjoyed using it and the code has been pretty easy to adapt into other projects.
I noticed a weird audio glitch in PMD when switching off the LFO right before a rest. Here's an example in MML:
In the current version of the PMD driver, the
c2note plays and quickly fades out, but then there's a short blip of sound again when ther2plays. I cross-referenced the PMD 4.8s source code, and apparently this was a bug fixed in version 4.8r. This PR applies the same fix to this project.The PR is larger than the actual fix because I had to move a few functions (the existing file didn't use any forward declarations, and I wanted to keep the same style). I also added label names from the PMD source code to the comments of the functions I updated, since it was helpful to me when cross-referencing them. Let me know if you'd like me to change anything, though, and I'd be happy to make updates.