Scottish Parliament parser fixes #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- should fetch more results based on the search returns, rather then the number of headers those link to.
SP can have divisions where everyone votes the same way - so there can be just one msplist
dracos
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two quick fixes:
1 - We're not always downloading the meetings of the parliament because there are no references to it till the second page. Parser was using the wrong variable to tell it when to stop. Fixed that and it pulls down more consistently.
2 - In the Scottish Parliament (because of electronic voting) they sometimes hold votes where everyone is on one side of a division. There was an assumption in the parser when converting that there would be at least 2 MSP lists. Changing a 1 to a 0 makes it happy and things get processed correctly. #193