-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations update from Hosted Weblate #289
base: main
Are you sure you want to change the base?
Conversation
Currently translated at 54.8% (91 of 166 strings) Translation: ytify/web Translate-URL: https://hosted.weblate.org/projects/ytify/web/ro/
WalkthroughThe changes update the Romanian localization file by adding several new key-value pairs for settings translations. The diff adds translations for entries such as search, display suggestions, playback, high-quality audio, codec preference, proxy streams, stable volume, library, default tab setting, discoveries storage and clearance, history storage, theming schemes, and cloud synchronization. These modifications ensure that the application displays the correct Romanian text for each setting. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/locales/ro.json (1)
106-110
: Library and discovery translations updated.
The entries for"settings_library"
,"settings_set_as_default_tab"
,"settings_store_discoveries"
,"settings_clear_discoveries"
, and"settings_store_history"
have been added with clear Romanian translations.
- Note: For
"settings_set_as_default_tab": "Setează ca Tab împlicit"
, consider whether"împlicit"
is a typographical error and should be"implicit"
.- Note: In
"settings_clear_discoveries": "Asta va goli $ discoperirile tale existente, continuă?"
, please verify that the placeholder$
is intentional. If a variable placeholder is needed, a more descriptive format (e.g.,{count}
) might improve clarity.If you’d like, I can propose a diff to update the potential typo:
- "settings_set_as_default_tab": "Setează ca Tab împlicit", + "settings_set_as_default_tab": "Setează ca Tab implicit",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/locales/ro.json
(3 hunks)
🔇 Additional comments (5)
src/locales/ro.json (5)
97-97
: Translation for "settings_search" added.
The new key provides the correct translation"Căutare"
, which is consistent with similar navigation keys (e.g.,"nav_search"
).
99-104
: Settings translations for display and media preferences updated.
The translations for"settings_display_suggestions"
,"settings_playback"
,"settings_hq_audio"
,"settings_codec_preference"
,"settings_always_proxy_streams"
, and"settings_stable_volume"
are clear and appropriate. Verify that the terminology matches the design guidelines used elsewhere in the application.
125-127
: Theming scheme translations (system, light, dark) added.
The new entries"settings_theming_scheme_system": "Sistem"
,"settings_theming_scheme_light": "Luminos"
, and"settings_theming_scheme_dark": "Întunecat"
are concise and align well with the overall localization strategy.
129-131
: Additional theming entries for High Contrast and color options updated.
The translations"settings_theming_scheme_hc_system": "Sistem"
,"settings_theming_scheme_white": "Alb"
, and"settings_theming_scheme_black": "Negru"
effectively complete the theming group.
161-162
: Watchmode and Library Sync translations are well integrated.
The translation for"settings_watchmode": "Modul video"
remains consistent with the existing UI elements, and the addition of"settings_library_sync": "Sincronizare Cloud"
enhances overall localization by covering new functionality.
Translations update from Hosted Weblate for ytify/web.
Current translation status:
Summary by CodeRabbit