fix: fix silent failure to add data of more than ~16MB via add_bytes or add_bytes_named #36
Conversation
Some errors don't happen if you use the mem transport. Also fix bug where add_bytes fails if the bytes are larger than the max frame size.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/36/docs/iroh_blobs/ Last updated: 2024-12-12T14:47:49Z |
| @@ -363,6 +372,15 @@ version = "0.1.2" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "597bb81c80a54b6a4381b23faba8d7774b144c94cbd1d6fe3f1329bd776554ab" | |||
|
|
|||
| [[package]] | |||
| name = "bincode" | |||
There was a problem hiding this comment.
why is this making a comback?
There was a problem hiding this comment.
what? How did this get here?
There was a problem hiding this comment.
Ok, it was via quic-rpc, where I forgot to remove the feature from tokio-serde.
It is gone now:
❯ cargo tree --all-features -i bincode
error: package ID specification `bincode` did not match any packages
There was a problem hiding this comment.
But the Cargo.lock file here still has bincode here, right?
Why does cargo tree tell you it's not in there, but the Cargo.lock file in this PR still adds it?
There was a problem hiding this comment.
@rklaehn did you give up fixing this?
There was a problem hiding this comment.
will be in the next PR.
# Conflicts: # Cargo.lock
Description
Breaking Changes
None
Notes & open questions
Change checklist