feat: direct connection callback #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first attempt for some kind of callback API for when a direct connection is established between an endpoint and a peer
ramfox
force-pushed
the
ramfox/direct_conn_cb
branch
from
a206749 to
dc3e308
Compare
src/magic_endpoint.rs
Outdated
| /// Does not block. The provided callback will be called when we have a direct | ||
| /// connection to the peer associated with the `node_id`, or the timeout has occurred. | ||
| /// | ||
| /// To wait indefinitely, provide -1 for the timeout parameter. |
There was a problem hiding this comment.
what timeout parameter?
|
want to rebase, so we can get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magic_endpoint_conn_type_cbcalls a callback for eachConnectionTypeevent we receive.main.cusesmagic_endpoint_conn_type_cbon the client side.