Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Do not test nightly rust on every PR #1940

Merged
merged 35 commits into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
5780741
chore(ci): Do not test nightly rust on every PR
flub Jan 8, 2024
15d817a
is it happier like this?
flub Jan 8, 2024
c423ec5
try as not a list?
flub Jan 8, 2024
a3b2e19
of course we have this twice
flub Jan 8, 2024
7a6201d
one of these must work surely
flub Jan 8, 2024
53a0a78
Try hooking up notifications
flub Jan 11, 2024
10c0641
test
flub Jan 11, 2024
808953d
try depend on upstream jobs
flub Jan 11, 2024
42c9332
unknown jobs? sad
flub Jan 11, 2024
dcc259f
sad
flub Jan 11, 2024
1660eb5
do not run all tests while playing around
flub Jan 11, 2024
37e01ee
show me some more
flub Jan 11, 2024
2143eda
better name
flub Jan 11, 2024
743f28c
show me some results
flub Jan 11, 2024
a905c64
disable some stuff to test
flub Jan 11, 2024
0f7953d
add some links
flub Jan 11, 2024
18699ee
maybe don't parse ahead of time?
flub Jan 11, 2024
086b8c8
single-line json?
flub Jan 11, 2024
d38b979
single quotes
flub Jan 11, 2024
7157d85
use extracted results
flub Jan 11, 2024
5a8d20c
what now?
flub Jan 11, 2024
2562320
f
flub Jan 11, 2024
d386fd2
go
flub Jan 11, 2024
e83a096
what
flub Jan 11, 2024
2e6c5ab
oh
flub Jan 11, 2024
7c3170a
lol me
flub Jan 11, 2024
b8be0c7
c
flub Jan 11, 2024
5bcf7cf
always anyway?
flub Jan 11, 2024
a7fd2d0
quotes for the lulz
flub Jan 11, 2024
bd86025
spelling, it's hard
flub Jan 11, 2024
59979fd
get tests back in full
flub Jan 11, 2024
ee93ded
make this pass again
flub Jan 11, 2024
7405527
Fixup triggers to the non-testing values
flub Jan 11, 2024
3b25258
Merge branch 'main' into flub/ci-beta-rust
flub Jan 11, 2024
da93f07
Merge branch 'main' into flub/ci-beta-rust
flub Jan 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/beta.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Run tests using the beta Rust compiler

name: Beta Rust

on:
schedule:
# 06:50 UTC every Monday
- cron: '50 6 * * 1'
workflow_dispatch:

concurrency:
group: beta-${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
tests:
uses: './.github/workflows/tests.yaml'
with:
rust-version: beta
notify:
needs: tests
if: ${{ always() }}
runs-on: ubuntu-latest
steps:
- name: Extract test results
run: |
printf '${{ toJSON(needs) }}\n'
result=$(echo '${{ toJSON(needs) }}' | jq -r .tests.result)
echo TESTS_RESULT=$result
echo "TESTS_RESULT=$result" >>"$GITHUB_ENV"
- name: Notify discord on failure
uses: n0-computer/discord-webhook-notify@v1
if: ${{ env.TESTS_RESULT == 'failure' }}
with:
severity: error
details: |
Rustc beta tests failed
See https://github.com/n0-computer/iroh/actions/workflows/beta.yaml
webhookUrl: ${{ secrets.DISCORD_N0_GITHUB_CHANNEL_WEBHOOK_URL }}

10 changes: 7 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ name: Tests
on:
workflow_call:
inputs:
rust-version:
description: 'The version of the rust compiler to run'
type: string
default: 'stable'
flaky:
description: 'Whether to also run flaky tests'
type: boolean
Expand All @@ -29,7 +33,7 @@ jobs:
fail-fast: false
matrix:
name: [ubuntu-latest, macOS-arm-latest]
rust: [nightly, stable]
rust: [ '${{ inputs.rust-version }}' ]
features: [all, none, default]
include:
- name: ubuntu-latest
Expand All @@ -52,7 +56,7 @@ jobs:
with:
ref: ${{ inputs.git-ref }}

- name: Install ${{ matrix.rust }}
- name: Install ${{ matrix.rust }} rust
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ matrix.rust }}
Expand Down Expand Up @@ -114,7 +118,7 @@ jobs:
fail-fast: false
matrix:
name: [windows-latest]
rust: [nightly, stable]
rust: [ '${{ inputs.rust-version}}' ]
features: [all, none, default]
target:
- x86_64-pc-windows-msvc
Expand Down
Loading