Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix important readme design issue (flat square style consistency) #2931

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

matheus23
Copy link
Member

Description

It's important.
Before:
image
After:
image

See? A much better "failing" badge :|

Breaking Changes

If at all, this un-breaks me tbh.

Notes & open questions

How come I look this rarely at the readme.

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.

@matheus23 matheus23 self-assigned this Nov 14, 2024
Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES, PR OF THE YEAR

Copy link

github-actions bot commented Nov 14, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2931/docs/iroh/

Last updated: 2024-11-14T15:56:02Z

@matheus23 matheus23 enabled auto-merge November 14, 2024 15:55
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 9bc0521

@matheus23 matheus23 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 5acce9c Nov 14, 2024
26 of 27 checks passed
@dignifiedquire dignifiedquire deleted the matheus23/readme-design-issue branch November 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants