Skip to content

refactor(iroh)!: remove unused utilities#2948

Merged
dignifiedquire merged 2 commits intomainfrom
dependency-purge
Nov 19, 2024
Merged

refactor(iroh)!: remove unused utilities#2948
dignifiedquire merged 2 commits intomainfrom
dependency-purge

Conversation

@rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Nov 18, 2024

Description

almost none of them is heavy, and we have them as indirect dependencies anyway.

Breaking Changes

removes

  • util::fs/PathContent // iroh_bytes::util::fs::PathContent
  • util::fs/path_content_info // iroh_bytes::util::fs::path_content_info
  • util::fs/key_to_path // iroh_bytes::util::fs::key_to_path
  • util::fs/path_to_key // iroh_bytes::util::fs::path_to_key
  • util::fs/canonicalized_path_to_string // iroh_bytes::util::fs::canonicalized_path_to_string
  • util::io::* // iroh_bytes::util::io
  • util::progress::ProgressEmitter // removed
  • util::progress::ProgressAsyncReader // removed
  • util::progress::Progress // removed
  • util::progress::ProgressReader // removed
  • util::progress::ProgressReaderUpdate // removed

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

almost none of them is heavy, and we have them as indirect dependencies
anyway.
@rklaehn rklaehn changed the title refactor!: get rid of some dependencies refactor(iroh)!: get rid of some dependencies Nov 18, 2024
@github-actions
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2948/docs/iroh/

Last updated: 2024-11-18T18:33:24Z

@dignifiedquire
Copy link
Contributor

can you document where does utils got moved to/what's their replacement

@github-actions
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 4fe6e3f

@rklaehn
Copy link
Contributor Author

rklaehn commented Nov 18, 2024

can you document where does utils got moved to/what's their replacement

Document where? In the PR?

@dignifiedquire dignifiedquire added this pull request to the merge queue Nov 19, 2024
@dignifiedquire dignifiedquire changed the title refactor(iroh)!: get rid of some dependencies refactor(iroh)!: remove unused utilities Nov 19, 2024
Merged via the queue into main with commit 73e7d44 Nov 19, 2024
@Arqu Arqu deleted the dependency-purge branch November 20, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants